Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbaAOROl (ORCPT ); Wed, 15 Jan 2014 12:14:41 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:41727 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbaAOROh (ORCPT ); Wed, 15 Jan 2014 12:14:37 -0500 Date: Wed, 15 Jan 2014 11:11:47 -0600 From: Josh Cartwright To: Courtney Cavin Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , Sagar Dharia , Gilad Avidov , Michael Bohan Subject: Re: [PATCH v4 4/6] spmi: pmic_arb: add support for interrupt handling Message-ID: <20140115171147.GX8153@joshc.qualcomm.com> References: <0f3e257f098d5f1ec6e9f09ba4dbf055291f2d83.1389738151.git.joshc@codeaurora.org> <20140114234402.GD23276@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140114234402.GD23276@sonymobile.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 14, 2014 at 03:44:03PM -0800, Courtney Cavin wrote: > On Tue, Jan 14, 2014 at 07:41:38PM +0100, Josh Cartwright wrote: > > The Qualcomm PMIC Arbiter, in addition to being a basic SPMI controller, > > also implements interrupt handling for slave devices. Note, this is > > outside the scope of SPMI, as SPMI leaves interrupt handling completely > > unspecified. > > > > Extend the driver to provide a irq_chip implementation and chained irq > > handling which allows for these interrupts to be used. > > > > Signed-off-by: Josh Cartwright > > --- > > drivers/spmi/spmi-pmic-arb.c | 393 ++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 391 insertions(+), 2 deletions(-) [..] > > +struct spmi_pmic_arb_qpnpint_type { > > + u8 type; /* 1 -> edge */ > > + u8 polarity_high; > > + u8 polarity_low; > > +} __packed; > > + > > While the rest of this driver uses 'pmic' or 'spmi_pmic', this patch > adds 'qpnpint'. Can we please just leave the software fabricated name > 'qpnp' out of any changes, as it isn't in any hardware spec? Perhaps > 'pmic_int' or something along those lines? QPNP is not a software-created concept. It is a hardware concept, where it places requirements on the layout of a peripherals' register space, and how interrupts are expected to behave, among other things. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/