Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752581AbaAOUeq (ORCPT ); Wed, 15 Jan 2014 15:34:46 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:41563 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752538AbaAOUeo (ORCPT ); Wed, 15 Jan 2014 15:34:44 -0500 Date: Wed, 15 Jan 2014 15:34:42 -0500 From: Steven Rostedt To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Frederic Weisbecker , Peter Zijlstra , Ingo Molnar , Namhyung Kim , LKML , Jiri Olsa Subject: Re: [PATCH 14/17] tools lib traceevent: Unregister handler when cfg80211 plugin unloaded Message-ID: <20140115153442.11b04413@gandalf.local.home> In-Reply-To: <1389750340-15965-15-git-send-email-namhyung@kernel.org> References: <1389750340-15965-1-git-send-email-namhyung@kernel.org> <1389750340-15965-15-git-send-email-namhyung@kernel.org> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jan 2014 10:45:37 +0900 Namhyung Kim wrote: > The function handler should be unregistered when the plugin unloaded > otherwise it'll try to access invalid memory. > > Cc: Jiri Olsa > Signed-off-by: Namhyung Kim > --- > tools/lib/traceevent/plugin_cfg80211.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/lib/traceevent/plugin_cfg80211.c b/tools/lib/traceevent/plugin_cfg80211.c > index dcab8e873c21..7b07d149557b 100644 > --- a/tools/lib/traceevent/plugin_cfg80211.c > +++ b/tools/lib/traceevent/plugin_cfg80211.c > @@ -22,3 +22,10 @@ int PEVENT_PLUGIN_LOADER(struct pevent *pevent) > PEVENT_FUNC_ARG_VOID); > return 0; > } > + > +void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent) > +{ > + pevent_unregister_print_function(pevent, > + process___le16_to_cpup, > + "__le16_to_cpup"); > +} Can we format this a little nicer: pevent_unregister_print_function(pevent, process___le16_to_cpup, "__le16_to_cpup"); I know the register had that separated, but that's because it had args too, and it made it look nicer. But this don't work here. It looks odd. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/