Date: Wed, 15 Jan 2014 16:30:00 -0800 (PST)
Message-ID: <87vbxk7oqu.wl%kuninori.morimoto.gx@gmail.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jean-Francois Moine <moinejf@free.fr>, alsa-devel@alsa-project.org,
        Xiubo Li <Li.Xiubo@freescale.com>, lgirdwood@gmail.com,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] Problems with simple-card
In-Reply-To: <20140115185621.GL15567@sirena.org.uk>
References: <20140115191831.5965d17e@armhf>
	<20140115185621.GL15567@sirena.org.uk>
User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

Hi

> > The main problem is about sysclk: when there is no clock in the DT,
> > you get the clock of the CPU or CODEC DAI. In my system, two clocks
> > are declared in the controller CPU DAI, but there is no .set_sysclk
> > pointer. So, snd_soc_dai_set_sysclk() returns -EINVAL and the card is
> > not created.
> 
> set_sysclk() should be returning -ENOTSUPP in this case as with
> set_fmt() and the generic code then ignoring that error.
> 
> > As I don't know why you need these fmt and sysclk, may you have a
> > look at these problems?
> 
> The overwhelming majority of combinations of devices need a format
> specifying (usually one will be imposed by the system design even if
> both devices could be master).

If my understanding is correct, this patch is the reason ?

71467e46414d3bab220de77d3d085be0c0aa03e1
(ASoC: simple-card: Add device's module clock selection)
    
It seems break non .set_sysclk drivers.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/