Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596AbaAPBjs (ORCPT ); Wed, 15 Jan 2014 20:39:48 -0500 Received: from nasmtp01.atmel.com ([192.199.1.245]:56163 "EHLO DVREDG01.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752407AbaAPBjq (ORCPT ); Wed, 15 Jan 2014 20:39:46 -0500 Message-ID: <52D7382C.4080705@atmel.com> Date: Thu, 16 Jan 2014 09:38:52 +0800 From: Bo Shen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Nicolas Ferre CC: , , , , , , "Rob Herring" , Pawel Moll , "Mark Rutland" , Stephen Warren , Ian Campbell , Rob Landley , Mark Brown , , Subject: Re: [PATCH 3/3] Binding: atmel-wm8904: add option to choose clock References: <1389669956-2304-1-git-send-email-voice.shen@atmel.com> <1389669956-2304-4-git-send-email-voice.shen@atmel.com> <52D6C2A1.4080405@atmel.com> In-Reply-To: <52D6C2A1.4080405@atmel.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, On 01/16/2014 01:17 AM, Nicolas Ferre wrote: > On 14/01/2014 04:25, Bo Shen : >> Add the option to choose clock output on which pin connect to SSC. >> Default is on TK pin to SSC, add clk_from_rk_pin option, the clock > > Please do not use "_" in DT properties. It is a common pattern to use > "-" instead. OK, I will use "-" instead in next version. >> is on RK pin to SSC. >> >> Signed-off-by: Bo Shen >> --- >> >> Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> index 8bbe50c..68a5c1a 100644 >> --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> @@ -33,6 +33,8 @@ Required properties: >> >> Optional properties: >> - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt >> + - clk_from_rk_pin: according to hardware design, clk privide on rk pin > > typo + more description is needed: > Please tell that it is a boolean property, that by default it is using > the TK pin (like in the commit message in fact). OK, I will add more description for it. Thanks > Bye, > >> + to ssc device >> >> Example: >> sound { >> > > Best Regards, Bo Shen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/