Subject: Re: [PATCH] MODSIGN: Fix including certificate twice when the
 signing_key.x509
From: joeyli <jlee@suse.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
        Josh Boyer <jwboyer@redhat.com>, Randy Dunlap <rdunlap@xenotime.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Michal Marek <mmarek@suse.com>
In-Reply-To: <87eh49x3hh.fsf@rustcorp.com.au>
References: <1389249983-31265-1-git-send-email-jlee@suse.com>
	 <87eh49x3hh.fsf@rustcorp.com.au>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 16 Jan 2014 12:03:05 +0800
Message-ID: <1389844985.24105.288.camel@linux-s257.site>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org

於 三，2014-01-15 於 15:09 +1030，Rusty Russell 提到：
> >
> > v2:
> > Using '$(shell /bin/pwd)' instead of '$(shell pwd)' for more
> reliable
> > between different shells
> 
> Hmm, that's not a great test for equality.  How about:
> 
>      ifneq ($(realpath .), $(realpath $(srctree)))
> 
> That should cover all the cases.
> 
> Cheers,
> Rusty. 

Yes, it's better!

Thanks for your suggestion, I will send new version with changelog
updated.

Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/