Message-ID: <52D75BE2.1040708@zytor.com>
Date: Wed, 15 Jan 2014 20:11:14 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@linux.intel.com>
CC: Borislav Petkov <bp@suse.de>, linux-kernel@vger.kernel.org,
        aravind.gopalakrishnan@amd.com, tglx@linutronix.de,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86, cpu, amd: Add workaround for family 16h,
 erratum 793
References: <20140114230711.GS29865@pd.tnic> <tip-3b56496865f9f7d9bcb2f93b44c63f274f08e3b6@git.kernel.org> <52D5DC51.9010606@zytor.com> <20140115062817.GA11869@gmail.com> <20140115133619.GA32051@pd.tnic> <52D69291.8080003@linux.intel.com> <20140115183807.GA23486@gmail.com>
In-Reply-To: <20140115183807.GA23486@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 01/15/2014 10:38 AM, Ingo Molnar wrote:
> 
> Right, the fact that most of our MSR accesses today are 
> crash-on-failure, which happens to trigger crashes on a regular 
> schedule, where most of the crashes are 'harmless' situation except 
> that they crash the systems for good.
> 
> So I think defaulting to soft failures is the right approach.
> 

Well, as I said, as long as people don't start doing:

	BUG_ON(msr_read(...))

... 'cuz that's just silly.  Also, on 64 bits the code generated by
going from 2x32 bits to 1x64 and sometimes back can add up (on 32 bits
there is no difference.)

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/