From: Arnd Bergmann <arnd@arndb.de>
To: Jingchang Lu <b35083@freescale.com>
Subject: Re: [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support
Date: Thu, 16 Jan 2014 12:02:48 +0100
User-Agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; )
Cc: vinod.koul@intel.com, dan.j.williams@intel.com, shawn.guo@linaro.org,
        pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org, Alison Wang <b18965@freescale.com>
References: <1389839400-29728-1-git-send-email-b35083@freescale.com> <1389839400-29728-3-git-send-email-b35083@freescale.com>
In-Reply-To: <1389839400-29728-3-git-send-email-b35083@freescale.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201401161202.49333.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org

On Thursday 16 January 2014, Jingchang Lu wrote:
> Add Freescale enhanced direct memory(eDMA) controller support.
> This module can be found on Vybrid and LS-1 SoCs.
> 
> Signed-off-by: Alison Wang <b18965@freescale.com>
> Signed-off-by: Jingchang Lu <b35083@freescale.com>

Very nice! All my previous comments have been addressed, so

Acked-by: Arnd Bergmann <arnd@arndb.de>

One small comment still:

> +
> +static DEFINE_MUTEX(fsl_edma_mutex);
> +

I think this mutex should be part of struct fsl_edma_engine, not global.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/