Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574AbaAPXVI (ORCPT ); Thu, 16 Jan 2014 18:21:08 -0500 Received: from seldrel01.sonyericsson.com ([212.209.106.2]:2799 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbaAPXVD (ORCPT ); Thu, 16 Jan 2014 18:21:03 -0500 Date: Thu, 16 Jan 2014 15:20:48 -0800 From: Bjorn Andersson To: "Ivan T. Ivanov" CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Wolfram Sang , Grant Likely , Jean Delvare , Greg Kroah-Hartman , Martin Schwidefsky , James Ralston , Bill Brown , Matt Porter , Andy Shevchenko , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 1/2] i2c: qup: Add device tree bindings information Message-ID: <20140116232047.GK30911@sonymobile.com> References: <1389659437-16406-1-git-send-email-bjorn.andersson@sonymobile.com> <1389659437-16406-2-git-send-email-bjorn.andersson@sonymobile.com> <1389689841.2794.8.camel@iivanov-dev.int.mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1389689841.2794.8.camel@iivanov-dev.int.mm-sol.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 14 Jan 00:57 PST 2014, Ivan T. Ivanov wrote: > > Thanks Bjorn, > > I have prepared second version, but never send it out :-). > One thing suggested by Mark was missed in this version. Yeah, Mattew told me you we're assigned to other things and asked me to send out an update as I had gotten it to work on our boards. I did modify the wording of most of these to match how it is written in the other Qualcomm definitions. @Mark, would you rather have me change this to your suggested wording? > > > On Mon, 2014-01-13 at 16:30 -0800, Bjorn Andersson wrote: > > From: "Ivan T. Ivanov" > > [snip] > > + - clocks: Should contain the core clock and the AHB clock. > > + - clocks: a list of phandle + clock-specifier pairs for each entry in > + clock-names > This is in line with how it's written in other drivers, so if the DT maintainers doesn't disagree I would like to keep phandles out of the description. This specific line is a verbatime copy of the msm_serial documentation (same block, different mode)... > > + - clock-names: Should be "core" for the core clock and "iface" for the > > + AHB clock. > > + > > + - #address-cells: Should be <1> Address cells for i2c device address > > + - #size-cells: Should be <0> as i2c addresses have no size component > > + > > +Optional properties: > > + - clock-frequency: Should specify the desired i2c bus clock frequency in Hz, > > + default is 100kHz if omitted. > > + > > +Child nodes should conform to i2c bus binding. > > + > > +Example: > > + > > + i2c2: i2c@f9924000 { > > + compatible = "qcom,i2c-qup"; > > + reg = <0xf9924000 0x1000>; > > + interrupts = <0 96 0>; > > + > > + clocks = <&gcc_blsp1_qup2_i2c_apps_clk>, <&gcc_blsp1_ahb_clk>; > > In the light of the latest patches from Stephen, this could be > > + clocks = <&gcc GCC_BLSP1_QUP2_I2C_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>; Yes, that's exactly what I have in my dts. However as this is just an example I didn't feel it was worth tainting the documentation with all those capital letters ;) So unless DT maintainers disagree I would like to just keep it as an example. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/