Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbaAQBrA (ORCPT ); Thu, 16 Jan 2014 20:47:00 -0500 Received: from mail.kernelconcepts.de ([212.60.202.196]:36666 "EHLO mail.kernelconcepts.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbaAQBq4 (ORCPT ); Thu, 16 Jan 2014 20:46:56 -0500 X-Greylist: delayed 360 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Jan 2014 20:46:56 EST Message-ID: <52D88B6E.6010709@kernelconcepts.de> Date: Fri, 17 Jan 2014 02:46:22 +0100 From: Simon Budig User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Dmitry Torokhov CC: =?ISO-8859-1?Q?Lothar_Wa=DFmann?= , linux-input@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Thierry Reding , Grant Likely , Jonathan Cameron , Shawn Guo , Silvio F , Guennadi Liakhovetski , Jingoo Han , Fugang Duan , Sachin Kamat , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 3/3] Input: edt-ft5x06: Add DT support References: <1389859338-11685-1-git-send-email-LW@KARO-electronics.de> <1389859338-11685-4-git-send-email-LW@KARO-electronics.de> <20140117002649.GA837@core.coreip.homeip.net> In-Reply-To: <20140117002649.GA837@core.coreip.homeip.net> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BALh93kiskoxb6g728lvuBjJemlgJjl5R" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BALh93kiskoxb6g728lvuBjJemlgJjl5R Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Dmitry On 17/01/14 01:26, Dmitry Torokhov wrote: >> + The following properties provide default values for the >> + corresponding parameters (see Documentation/input/edt-ft5x06.txt) >> +- edt,threshold: allows setting the "click"-threshold in the range fr= om 20 to 80. >> +- edt,gain: sensitivity (0..31) (lower value -> higher sensitivity) >> +- edt,offset: edge compensation (0..31) >> +- edt,report-rate: report rate (3..14) >=20 > I wonder if we really need to have it in device tree? Can users needing= > top tweak the settings do it via udev rules? IMO it makes sense to have these in the device tree. These values need to be adjusted if you have glass or acrylics in front of the touch glass. The defaults are tailored to the touchscreen without any (additional) material in front of it. So manufacturers need to provide different defaults depending on the way a specific device is built. So these properties can be viewed in the same way you specify display resolution or display type in the device tre= e. Bye, Simon --=20 Simon Budig kernel concepts GmbH simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48 +49-271-771091-17 D-57072 Siegen --BALh93kiskoxb6g728lvuBjJemlgJjl5R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlLYi24ACgkQO2O/RXesiHAlCgCglXbccRZKZoEn4WzdUpJ35ZtU DjkAn2w6BsHgr66lFkpu7k6/QyWW3err =iVxg -----END PGP SIGNATURE----- --BALh93kiskoxb6g728lvuBjJemlgJjl5R-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/