Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbaAQMVH (ORCPT ); Fri, 17 Jan 2014 07:21:07 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:38501 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbaAQMVE (ORCPT ); Fri, 17 Jan 2014 07:21:04 -0500 Date: Fri, 17 Jan 2014 12:20:52 +0000 From: Matt Fleming To: "Rafael J. Wysocki" Cc: "H. Peter Anvin" , joeyli , Alessandro Zummo , Matthew Garrett , Elliott@hp.com, samer.el-haj-mahmoud@hp.com, Oliver Neukum , werner@suse.com, trenn@suse.de, JBeulich@suse.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, x86@kernel.org, "linux-efi@vger.kernel.org" , linux-acpi@vger.kernel.org, Borislav Petkov Subject: Re: [RFT][PATCH] ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() (was: Re: [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME) Message-ID: <20140117122052.GG27632@console-pimps.org> References: <1387439053-8711-1-git-send-email-jlee@suse.com> <3476450.BMEcId2Lgj@vostro.rjw.lan> <20131221122148.GB29501@console-pimps.org> <2530951.HFPX8MI38t@vostro.rjw.lan> <20140112110546.GB25180@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140112110546.GB25180@console-pimps.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Jan, at 11:05:46AM, Matt Fleming wrote: > On Sun, 12 Jan, at 01:30:23AM, Rafael J. Wysocki wrote: > > On Saturday, December 21, 2013 12:21:48 PM Matt Fleming wrote: > > > On Fri, 20 Dec, at 11:18:56PM, Rafael J. Wysocki wrote: > > > > > > > > I'm not sure 100%, but I *think* we need to do that with interrupts enabled. > > > > At least after mm_init(), because it relies on things initialized there if I > > > > remember correctly. > > > > > > > > From what I can tell at the moment, it might be possible to move it before > > > > efi_enter_virtual_mode() if that would help. > > > > > > Actually yeah, that would be super useful, and I think we'd be able to > > > get rid of the whole efi_late_init() stuff because we'd no longer need > > > to hang on to the EFI_BOOT_SERVICES* regions after > > > SetVirtualAddressMap(). > > > > OK > > > > I don't see any adverse effects of the patch below on a couple of my test > > boxes, but (a) they are Intel-based and (b) they are non-EFI, so it would be > > good to give it a go on as many machines as reasonably possible. > > Thanks Rafael, I'll give this a spin on my test machines here. (Sorry for replying so late) As various other people have reported, this works fine. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/