Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751467AbaATHrZ (ORCPT ); Mon, 20 Jan 2014 02:47:25 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:36829 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbaATHrW (ORCPT ); Mon, 20 Jan 2014 02:47:22 -0500 MIME-Version: 1.0 In-Reply-To: <20140119173712.GA26481@kroah.com> References: <1390110907-29918-1-git-send-email-sj38.park@gmail.com> <20140119173712.GA26481@kroah.com> From: Mike Turquette Date: Sun, 19 Jan 2014 23:47:01 -0800 Message-ID: Subject: Re: [PATCH] clk: export __clk_get_hw for re-use in others To: Greg KH Cc: SeongJae Park , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 19, 2014 at 9:37 AM, Greg KH wrote: > On Sun, Jan 19, 2014 at 02:55:07PM +0900, SeongJae Park wrote: >> Following build comes while modprobe process: >> > ERROR: "__clk_get_hw" [drivers/clk/clk-max77686.ko] undefined! >> > make[2]: *** [__modpost] Error 1 >> > make[1]: *** [modules] Error 2 >> >> Export the symbol to fix it and for other part's usecase. >> >> Signed-off-by: SeongJae Park >> --- >> drivers/clk/clk.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c >> index 2b38dc9..3883fba 100644 >> --- a/drivers/clk/clk.c >> +++ b/drivers/clk/clk.c >> @@ -575,6 +575,7 @@ struct clk_hw *__clk_get_hw(struct clk *clk) >> { >> return !clk ? NULL : clk->hw; >> } >> +EXPORT_SYMBOL_GPL(__clk_get_hw); > > __ functions should usually only be for "internal" use, why does this > get exported to modules? Why not just put it in a .h file? It was originally used only within the clock core but it is sensible for hardware-specific clock drivers to use this as well. I plan to audit all of the double-underscore functions in include/linux/clk-provider.h for 3.15. Regards, Mike > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/