Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752327AbaATIhH (ORCPT ); Mon, 20 Jan 2014 03:37:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54302 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbaATIhC (ORCPT ); Mon, 20 Jan 2014 03:37:02 -0500 Date: Mon, 20 Jan 2014 09:38:36 +0100 From: Alexander Gordeev To: Keith Busch Cc: Bjorn Helgaas , Matthew Wilcox , "linux-kernel@vger.kernel.org" , linux-nvme@lists.infradead.org, "linux-pci@vger.kernel.org" Subject: Re: [PATCH v2 5/9] nvme: Fix invalid call to irq_set_affinity_hint() Message-ID: <20140120083835.GA19068@dhcp-26-207.brq.redhat.com> References: <1c441f670f33375b6c41e074baf6e84e6c7bb0c2.1389904166.git.agordeev@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 17, 2014 at 03:01:10PM -0700, Keith Busch wrote: > >dev->entry[0].vector is initialized in nvme_dev_map(), and it's used > >for free_irq() above the area of your patch, so I don't think this is > >actually a bug, though it might be somewhat confusing. > > It is confusing, but there's a reason. :) > > We send a single command using legacy irq to discover how many msix > vectors we want. The legacy entry needs to be set some time before calling > request_irq in nvme_configure_admin_queue, but also within nvme_dev_start > (for power-management). I don't think there's a place to set it that > won't look odd when looking at nvme_setup_io_queues. I settled on > 'nvme_dev_map' was because 'nvme_dev_unmap' invalidates the entries, > so this seemed to provide some amount of symmetry. I am sending v3 of the patch which concerns Bjorn's comment. I am also sending two follow-up patches an attempt to make nvme_dev_start() more readable and fix couple of (what I suspect are) issues. Thanks! -- Regards, Alexander Gordeev agordeev@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/