Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbaATLBP (ORCPT ); Mon, 20 Jan 2014 06:01:15 -0500 Received: from mga02.intel.com ([134.134.136.20]:17283 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbaATLBN (ORCPT ); Mon, 20 Jan 2014 06:01:13 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,689,1384329600"; d="scan'208";a="441610948" Date: Mon, 20 Jan 2014 15:29:17 +0530 From: Vinod Koul To: Jonas Jensen Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, dan.j.williams@intel.com Subject: Re: [PATCH] dma: fix vchan_cookie_complete() debug print Message-ID: <20140120095917.GZ26823@intel.com> References: <1386344529-25617-1-git-send-email-jonas.jensen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386344529-25617-1-git-send-email-jonas.jensen@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 06, 2013 at 04:42:09PM +0100, Jonas Jensen wrote: > vd->tx.cookie is set zero on dma_cookie_complete(), > save to local before printing it. > > Signed-off-by: Jonas Jensen > --- > > Notes: > dev_vdbg() could also be moved to happen earlier, what do you prefer? This would be preferred IMHO. Also pls cc dmaengine@vger on this -- ~Vinod > > Applies to next-20131206 > > drivers/dma/virt-dma.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h > index 85c19d6..181b9526 100644 > --- a/drivers/dma/virt-dma.h > +++ b/drivers/dma/virt-dma.h > @@ -84,10 +84,12 @@ static inline bool vchan_issue_pending(struct virt_dma_chan *vc) > static inline void vchan_cookie_complete(struct virt_dma_desc *vd) > { > struct virt_dma_chan *vc = to_virt_chan(vd->tx.chan); > + dma_cookie_t cookie; > > + cookie = vd->tx.cookie; > dma_cookie_complete(&vd->tx); > dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n", > - vd, vd->tx.cookie); > + vd, cookie); > list_add_tail(&vd->node, &vc->desc_completed); > > tasklet_schedule(&vc->task); > -- > 1.8.2.1 > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/