Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753236AbaATLxY (ORCPT ); Mon, 20 Jan 2014 06:53:24 -0500 Received: from mail-oa0-f47.google.com ([209.85.219.47]:48564 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbaATLxW (ORCPT ); Mon, 20 Jan 2014 06:53:22 -0500 MIME-Version: 1.0 In-Reply-To: <20140120100530.GY15937@n2100.arm.linux.org.uk> References: <1390208555-27770-1-git-send-email-tushar.behera@linaro.org> <1390208555-27770-2-git-send-email-tushar.behera@linaro.org> <20140120100530.GY15937@n2100.arm.linux.org.uk> Date: Mon, 20 Jan 2014 17:23:21 +0530 Message-ID: Subject: Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe From: Tushar Behera To: Russell King - ARM Linux Cc: lkml , linux-serial , linux-samsung-soc , jslaby , Greg Kroah-Hartman , Ben Dooks , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20 January 2014 15:35, Russell King - ARM Linux wrote: > On Mon, Jan 20, 2014 at 02:32:34PM +0530, Tushar Behera wrote: >> uart_register_driver call binds the driver to a specific device >> node through tty_register_driver call. This should typically happen >> during device probe call. >> >> In a multiplatform scenario, it is possible that multiple serial >> drivers are part of the kernel. Currently the driver registration fails >> if multiple serial drivers with same default major/minor numbers are >> included in the kernel. >> >> A typical case is observed with amba-pl011 and samsung-uart drivers. > > The samsung-uart driver is at fault here - the major/minor numbers were > officially registered to amba-pl011. Samsung needs to be fixed properly. > I had earlier submitted a patch [1] to remove the hard coded major/minor number for Samsung UART driver, but that was rejected because of userspace breakage. Without this patch, Samsung UART driver can't bind to the hard-coded device node. Changing the default major/minor will also not help to fix the objections raised in [1]. Would you please suggest a way forward? [1] https://lkml.org/lkml/2013/12/27/2 -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/