Message-ID: <52DD18A5.1090308@imgtec.com>
Date: Mon, 20 Jan 2014 12:37:57 +0000
From: James Hogan <james.hogan@imgtec.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>
CC: Chen Gang <gang.chen.5i5j@gmail.com>, <devel@driverdev.osuosl.org>,
        <andreas.dilger@intel.com>, Greg KH <gregkh@linuxfoundation.org>,
        <bergwolf@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        <oleg.drokin@intel.com>, <jacques-charles.lafoucriere@cea.fr>,
        <jinshan.xiong@intel.com>, <linux-metag@vger.kernel.org>
Subject: Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))"
 for the related union
References: <52DA4E6A.1000308@gmail.com> <20140118100547.GS7444@mwanda> <52DA56C2.5010802@gmail.com> <20140118142404.GT7444@mwanda> <52DBA3D4.3090308@gmail.com> <52DD0EFF.2010305@imgtec.com> <20140120123045.GV7444@mwanda>
In-Reply-To: <20140120123045.GV7444@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 20/01/14 12:30, Dan Carpenter wrote:
> Ah.  From so metag is a new arch and not a compiler like the changelog
> says.
> 
> On Mon, Jan 20, 2014 at 11:56:47AM +0000, James Hogan wrote:
>> struct a {
>> 	struct b {
>> 		unsigned int x;
>> 		unsigned short y;
>> 	} x;
>> 	unsigned short y;
>> } __packed;
> 
> This is not the code we are discussing.  It should look like:
> 
> struct a {
> 	union {
> 		short x;
> 		short y;
> 	}
> 	short z;
> };
> 
> Any normal person would assume that sizeof(struct a) would be 4 but
> apparently on metag it is 8.  That totally defeats the point of using
> a union in the first place.  It's easy enough to add a __packed to the
> lustre declaration but I expect this to cause an endless stream of bugs.
> 
> It it is really stupid.

I agree completely (and did request this be changed when I first found
out about it, but since it's an ABI issue it was really too late).
That's why I'm not actively pushing for every case to be fixed unless
it's in generic code that actually affects metag.

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/