Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753910AbaATOsV (ORCPT ); Mon, 20 Jan 2014 09:48:21 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:43514 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbaATOsT (ORCPT ); Mon, 20 Jan 2014 09:48:19 -0500 Date: Mon, 20 Jan 2014 14:48:16 +0000 From: Matt Fleming To: Borislav Petkov Cc: Linux EFI , LKML , Borislav Petkov , Matthew Garrett , "H. Peter Anvin" , Toshi Kani Subject: Re: [PATCH 5/5] efi: Split efi_enter_virtual_mode Message-ID: <20140120144816.GC684@console-pimps.org> References: <1390045698-16882-1-git-send-email-bp@alien8.de> <1390045698-16882-6-git-send-email-bp@alien8.de> <20140120134407.GB684@console-pimps.org> <20140120134625.GD3003@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140120134625.GD3003@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jan, at 02:46:25PM, Borislav Petkov wrote: > On Mon, Jan 20, 2014 at 01:44:07PM +0000, Matt Fleming wrote: > > > +void __init kexec_enter_virtual_mode(void) > > > +{ > > > > Could this be static for now? > > Didn't you wanna do arch/x86/platform/efi/kexec.c anyway? Yes, but the patches are easier to review if we make kexec_enter_virtual_mode() global when moving it into a new file. Plus it makes this patch that little bit smaller because the modification to efi.h is unnecessary. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/