Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752649AbaATTjl (ORCPT ); Mon, 20 Jan 2014 14:39:41 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:42776 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752544AbaATTja (ORCPT ); Mon, 20 Jan 2014 14:39:30 -0500 Date: Mon, 20 Jan 2014 19:39:25 +0000 From: Luis Henriques To: Benjamin Herrenschmidt , Paul Mackerras , Anton Blanchard , Ian Munsie Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc: Fix build dependencies for storcenter Message-ID: <20140120193921.GA5267@hercules> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes a build failure that seems to be present since commit commit b81f18e55e9f4ea81759bcb00fea295de679bbe8 Author: Tony Breeds Date: Tue Apr 3 15:00:39 2012 +0000 powerpc/boot: Only build board support files when required. This is easily reproducible my using the storcenter_defconfig config file: arch/powerpc/boot/cuboot-pq2.o: In function `pq2_platform_fixups': cuboot-pq2.c:(.text+0x30c): undefined reference to `fsl_get_immr' make[1]: *** [arch/powerpc/boot/cuImage.storcenter] Error 1 Fixes: b81f18e55e9f ("powerpc/boot: Only build board support files when required.") Cc: Tony Breeds Cc: (3.6+) Signed-off-by: Luis Henriques --- arch/powerpc/boot/Makefile | 2 +- arch/powerpc/boot/wrapper | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index 981d418..cf8e5db 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -95,7 +95,7 @@ src-plat-$(CONFIG_FSL_SOC_BOOKE) += cuboot-85xx.c cuboot-85xx-cpm2.c src-plat-$(CONFIG_EMBEDDED6xx) += cuboot-pq2.c cuboot-mpc7448hpc2.c \ cuboot-c2k.c gamecube-head.S \ gamecube.c wii-head.S wii.c holly.c \ - prpmc2800.c + prpmc2800.c fsl-soc.c src-plat-$(CONFIG_AMIGAONE) += cuboot-amigaone.c src-plat-$(CONFIG_PPC_PS3) += ps3-head.S ps3-hvcall.S ps3.c src-plat-$(CONFIG_EPAPR_BOOT) += epapr.c epapr-wrapper.c diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper index 2e1af74..4d90b98 100755 --- a/arch/powerpc/boot/wrapper +++ b/arch/powerpc/boot/wrapper @@ -190,9 +190,12 @@ cuboot*) *5200*|*-motionpro) platformo=$object/cuboot-52xx.o ;; - *-pq2fads|*-ep8248e|*-mpc8272*|*-storcenter) + *-pq2fads|*-ep8248e|*-mpc8272*) platformo=$object/cuboot-pq2.o ;; + *-storcenter) + platformo="$object/cuboot-pq2.o $object/fsl-soc.o" + ;; *-mpc824*) platformo=$object/cuboot-824x.o ;; -- 1.8.3.2 Cheers, -- Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/