Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbaATT54 (ORCPT ); Mon, 20 Jan 2014 14:57:56 -0500 Received: from relay1.sgi.com ([192.48.179.29]:56246 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbaATT5y (ORCPT ); Mon, 20 Jan 2014 14:57:54 -0500 Date: Mon, 20 Jan 2014 13:58:12 -0600 From: Alex Thorlton To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Andrew Morton , "Kirill A. Shutemov" , Benjamin Herrenschmidt , Rik van Riel , Naoya Horiguchi , Oleg Nesterov , "Eric W. Biederman" , Andy Lutomirski , Al Viro , Kees Cook , Andrea Arcangeli Subject: Re: [RFC PATCHv2 2/2] Change khugepaged to respect MMF_THP_DISABLE flag Message-ID: <20140120195812.GD18196@sgi.com> References: <1bc8f911363af956b37d8ea415d734f3191f1c78.1389905087.git.athorlton@sgi.com> <13c9d1b0213af7cee7afb54de368a0b189e98df8.1389905087.git.athorlton@sgi.com> <20140118234957.GB10970@node.dhcp.inet.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140118234957.GB10970@node.dhcp.inet.fi> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 19, 2014 at 01:49:57AM +0200, Kirill A. Shutemov wrote: > __khugepaged_enter() has VM_BUG_ON(khugepaged_test_exit(mm)). > Do we really want to crash there if MMF_THP_DISABLE is set? No, definitely not. Upon review, khugepaged_test_exit is the wrong place to do this check. I think I need to move it up to khugepaged_scan_mm_slot for this to work correctly. Thanks for pointing that out, Kirill. - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/