Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbaATVwY (ORCPT ); Mon, 20 Jan 2014 16:52:24 -0500 Received: from merlin.infradead.org ([205.233.59.134]:39455 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbaATVwU (ORCPT ); Mon, 20 Jan 2014 16:52:20 -0500 Date: Mon, 20 Jan 2014 22:51:51 +0100 From: Peter Zijlstra To: Len Brown Cc: Ingo Molnar , "H. Peter Anvin" , Stephen Rothwell , Thomas Gleixner , Ingo Molnar , linux-next@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: linux-next: build failure after merge of the tip tree Message-ID: <20140120215151.GN31570@twins.programming.kicks-ass.net> References: <20140116145829.5e4fcab103b1c5c77501ee77@canb.auug.org.au> <20140116121955.GQ31570@twins.programming.kicks-ass.net> <20140117074628.88698f59939c9002b7c12968@canb.auug.org.au> <20140120082620.GB30183@twins.programming.kicks-ass.net> <52DCE4CF.2060605@zytor.com> <20140120091600.GW31570@twins.programming.kicks-ass.net> <52DCEAF4.3040902@zytor.com> <20140120092931.GA3836@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2014 at 04:39:45PM -0500, Len Brown wrote: > > As a side note, at minimum the semantic and compatibility difference > > needs to be _very_ clearly present in the naming. Something like > > mwait_old_() or mwait_core2_(). That way such dependencies and > > assumptions don't get lost in code restructuring, etc. > > Agreed. > We started with mwait_idle() -- which was erroneously removed > and is now being restored under it original name. > > The "new" function is mwait_idle_with_hints() -- which uses > the additional hints that were not available w/ the original MWAIT instruction. > Where "new" is Core Duo and later -- all the processor that can use > MWAIT for C-states deeper than C1. I'm still waiting for someone to explain what's wrong with: static inline void mwait_idle(void) { local_irq_enable(); mwait_idle_with_hints(0, 0); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/