Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753954AbaAUIfU (ORCPT ); Tue, 21 Jan 2014 03:35:20 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:56099 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753903AbaAUIfO (ORCPT ); Tue, 21 Jan 2014 03:35:14 -0500 Message-ID: <52DE3132.3000007@ti.com> Date: Tue, 21 Jan 2014 10:34:58 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Hans de Goede , , CC: , , , , , Subject: Re: [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support References: <1390228888-5537-1-git-send-email-rogerq@ti.com> <52DD5368.5020301@redhat.com> In-Reply-To: <52DD5368.5020301@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2014 06:48 PM, Hans de Goede wrote: > Hi, > > On 01/20/2014 03:41 PM, Roger Quadros wrote: >> Hi, >> >> Some platforms have a PHY hooked up to the SATA controller. >> The PHY needs to be initialized and powered up for SATA to work. >> We do that using the Generic PHY framework in PATCH 3. >> >> In order to support SATA on the OMAP platforms we need to runtime >> resume the device before use. PATCH 4 takes care of that. > > Thanks for keeping me in the loop on this. I'm afraid this conflicts > quite a bit with my recent ahci_platform.c work, not a big problem > really, the series can go in either way. > > Your phy support will slot nicely into the new ahci_platform_get_resources > and ahci_platform_enable_resources functions my refactoring introduces, > looking at it from this pov it might be better / easier to rebase your series > on top of the v4 of my series I've just send. > > Which brings me to one comment about your series why are you not doing phy_exit > and phy_init on suspend resp. resume ? The phy can use quite a bit of power, > if the phy init / exit end up in ahci_platform_enable_resources / > ahci_platform_disable_resources, this will happen automatically for better or > worse. So it would be good to test if this would work or not ... Right. Bartlomiej had pointed this out earlier, but I just wasn't very sure about it. Is it sufficient to just call phy_power_off() in suspend and phy_power_on() in resume? Or do we call phy_exit() and phy_init() respectively as well. Kishon, any suggestions? cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/