Date: Tue, 21 Jan 2014 01:51:52 -0800 (PST)
From: David Rientjes <rientjes@google.com>
To: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
cc: akpm@linux-foundation.org, hannes@cmpxchg.org, liuj97@gmail.com,
        santosh.shilimkar@ti.com, grygorii.strashko@ti.com,
        iamjoonsoo.kim@lge.com, robin.m.holt@gmail.com,
        tangchen@cn.fujitsu.com, yinghai@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable
In-Reply-To: <20140121075738.771d29b3@lilie>
Message-ID: <alpine.DEB.2.02.1401210150220.29987@chino.kir.corp.google.com>
References: <1390217559-14691-1-git-send-email-phacht@linux.vnet.ibm.com> <1390217559-14691-2-git-send-email-phacht@linux.vnet.ibm.com> <alpine.DEB.2.02.1401202214540.21729@chino.kir.corp.google.com> <20140121075738.771d29b3@lilie>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 21 Jan 2014, Philipp Hachtmann wrote:

> > Not sure why you don't just do a one line patch:
> > 
> > -	phys_addr_t size;
> > +	phys_addr_t size __maybe_unused;
> > to fix it.
> 
> Just because I did not know that __maybe_unused thing.
> 

-	phys_addr_t size;
+	phys_addr_t size = 0;

would have done the same thing.

The compiler generated code isn't going to change with either of these, so 
we're only talking about how the source code is structured.  If you and 
Andrew believe that adding block scope to something so trivial then that's 
your taste.  Looks ugly to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/