Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754181AbaAUKBn (ORCPT ); Tue, 21 Jan 2014 05:01:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5460 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753624AbaAUKBk (ORCPT ); Tue, 21 Jan 2014 05:01:40 -0500 Date: Tue, 21 Jan 2014 11:03:12 +0100 From: Alexander Gordeev To: Keith Busch Cc: Bjorn Helgaas , Matthew Wilcox , "linux-kernel@vger.kernel.org" , linux-nvme@lists.infradead.org, "linux-pci@vger.kernel.org" Subject: Re: [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak Message-ID: <20140121100311.GA8847@dhcp-26-207.brq.redhat.com> References: <1c441f670f33375b6c41e074baf6e84e6c7bb0c2.1389904166.git.agordeev@redhat.com> <20140120083835.GA19068@dhcp-26-207.brq.redhat.com> <20140120084212.GC19068@dhcp-26-207.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2014 at 03:48:56PM -0700, Keith Busch wrote: > On Mon, 20 Jan 2014, Alexander Gordeev wrote: > >This is an attempt to make handling of admin queue in a > >single scope. This update also fixes a IRQ leak in case > >nvme_setup_io_queues() failed to allocate enough iomem > >and bailed out with -ENOMEM errno. > > This definitely seems to improve the code flow, but this leak was already > fixed in the latest linux-nvme tree with this commit: > > http://git.infradead.org/users/willy/linux-nvme.git/commit/c5dc9192d52a4a3a479f701e97386347d454af84 Oh, that one seems to complicate things even further to me. Whould you consider the revert? Sending an improved version against your tree. -- Regards, Alexander Gordeev agordeev@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/