Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754653AbaAUNTK (ORCPT ); Tue, 21 Jan 2014 08:19:10 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:58009 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbaAUNTI (ORCPT ); Tue, 21 Jan 2014 08:19:08 -0500 MIME-Version: 1.0 In-Reply-To: <20140120133424.09328108@alan.etchedpixels.co.uk> References: <1389953232-9428-1-git-send-email-piastry@etersoft.ru> <1389953232-9428-2-git-send-email-piastry@etersoft.ru> <20140117181847.6c1f3831@alan.etchedpixels.co.uk> <20140120133424.09328108@alan.etchedpixels.co.uk> Date: Tue, 21 Jan 2014 17:19:06 +0400 X-Google-Sender-Auth: P2aBB9NH2SvgXJiWKKcnZPQaXCI Message-ID: Subject: Re: [PATCH v7 1/7] VFS: Introduce new O_DENY* open flags From: Pavel Shilovsky To: One Thousand Gnomes Cc: Kernel Mailing List , linux-cifs , linux-fsdevel , Linux NFS Mailing list , wine-devel@winehq.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014/1/20 One Thousand Gnomes : >> > Shouldn't this also check for CAP_SYS_DAC or some similar permission so >> > that root can override such a mess (eg to fix full disks in an >> > emergency) ? >> >> May be it's better to let root an ability to remount the system >> without sharelock mount option and then fix an emergency? > > Doesn't that involve breaking the service for all users of the system > relying upon those locks, while root being allowed to ignore the locks > does not ? If we allow root to remount without "sharelock" (or bypass conflict checks), it will definitely break the service for all users. Probably it's better to stop the service (that cause all sharelocks to be unlocked), fix the emergency and start the service again. In the current state, the patchset doesn't allow any sort of ignoring those locks for mounts with "sharelock" option (either remount without "sharelock" or set special capabilities). It was done to make sure nothing breaks applications relying upon sharelock behavior. Also, that's why "sharelock" mount option was added: this behavior is dangerous to be on critical system paths like "/" or "/lib" and not suitable for global use. -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/