Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754866AbaAUPud (ORCPT ); Tue, 21 Jan 2014 10:50:33 -0500 Received: from merlin.infradead.org ([205.233.59.134]:58739 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754607AbaAUPua (ORCPT ); Tue, 21 Jan 2014 10:50:30 -0500 Date: Tue, 21 Jan 2014 16:49:54 +0100 From: Peter Zijlstra To: Waiman Long Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Arnd Bergmann , linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt , Andrew Morton , Michel Lespinasse , Andi Kleen , Rik van Riel , "Paul E. McKenney" , Linus Torvalds , Raghavendra K T , George Spelvin , Tim Chen , aswin@hp.com, Scott J Norton Subject: Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock() Message-ID: <20140121154954.GC31570@twins.programming.kicks-ass.net> References: <1389761047-47566-1-git-send-email-Waiman.Long@hp.com> <1389761047-47566-5-git-send-email-Waiman.Long@hp.com> <20140120151855.GH30183@twins.programming.kicks-ass.net> <52DE9626.3030806@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52DE9626.3030806@hp.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2014 at 10:45:42AM -0500, Waiman Long wrote: > I can change the logic to use only cmpxchg for readers, but I don't see a > compelling reason to do so. The fact that you can then use smp_store_release() is fairly compelling methinks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/