Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbaAUTda (ORCPT ); Tue, 21 Jan 2014 14:33:30 -0500 Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:51837 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbaAUTd0 (ORCPT ); Tue, 21 Jan 2014 14:33:26 -0500 X-Forefront-Antispam-Report: CIP:165.204.84.222;KIP:(null);UIP:(null);IPV:NLI;H:atltwp02.amd.com;RD:none;EFVD:NLI X-SpamScore: -5 X-BigFish: VPS-5(zzbb2dI98dI9371I1432I4015Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah21bch1fc6hzz1de098h8275bh1de097hz2dh839h947hd25he5bhf0ah1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h1765h18e1h190ch1946h19b4h19c3h1ad9h1b0ah2222h224fh1d0ch1d2eh1d3fh1dfeh1dffh1f5fh1fe8h1ff5h209eh22d0h2336h2438h2461h2487h1155h) X-WSS-ID: 0MZRNMM-08-LU3-02 X-M-MSG: Message-ID: <52DECB5A.6030004@amd.com> Date: Tue, 21 Jan 2014 13:32:42 -0600 From: Aravind Gopalakrishnan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Ingo Molnar CC: , , , , , , , , , Subject: Re: [PATCH] x86, quirks: Add workaround for AMD F16h Erratum792 References: <1389983973-3965-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <20140120070724.GA31940@gmail.com> In-Reply-To: <20140120070724.GA31940@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-OriginatorOrg: amd.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/20/2014 1:07 AM, Ingo Molnar wrote: > * Aravind Gopalakrishnan wrote: > >> + >> +#if defined(CONFIG_PCI) >> +/* >> + * Apply AMD Fam16h Erratum792 >> + * see Revision Guide for AMD F16h models 00h-0fh, >> + * document 51810 rev. 3.04, Nov 2013 >> + */ >> +static void quirk_amd_dram_scrub(struct pci_dev *dev) > The reference to the erratum is useful for people who want to see more > details, but at least a short description of the problem being fixed > and systems affected by the quirk is needed. 'DRAM scrub' is not very > informative. > > Ok, I'll reword the comment in a V2. But there's an internal discussion going on about the erratum, so I'll hold off spinning a V2 until that's over.. Thanks, -Aravind. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/