Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864AbaAUUAF (ORCPT ); Tue, 21 Jan 2014 15:00:05 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:64713 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbaAUUAC (ORCPT ); Tue, 21 Jan 2014 15:00:02 -0500 Date: Tue, 21 Jan 2014 11:59:57 -0800 From: Dmitry Torokhov To: Alexey Khoroshilov Cc: Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] USB: input: gtco.c: fix usb_dev leak Message-ID: <20140121195957.GB29615@core.coreip.homeip.net> References: <1390087466-9898-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1390087466-9898-1-git-send-email-khoroshilov@ispras.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 19, 2014 at 03:24:26AM +0400, Alexey Khoroshilov wrote: > There is usb_get_dev() in gtco_probe(), but there is no usb_put_dev() > anywhere in the driver. > > The patch adds usb_get_dev() to failure handling code of gtco_probe() > and to gtco_disconnect((). Hmm, I think gtco should simply not use usb_get_dev() in the first place. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/