Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286AbaAVBYm (ORCPT ); Tue, 21 Jan 2014 20:24:42 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:56105 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbaAVBYk (ORCPT ); Tue, 21 Jan 2014 20:24:40 -0500 Message-ID: <52DF1D59.8090803@huawei.com> Date: Wed, 22 Jan 2014 09:22:33 +0800 From: Xishi Qiu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Vegard Nossum CC: Ingo Molnar , "H. Peter Anvin" , "Vegard Nossum" , Pekka Enberg , Mel Gorman , , the arch/x86 maintainers , LKML , Linux MM Subject: Re: [PATCH] mm: add a new command-line kmemcheck value References: <52C2811C.4090907@huawei.com> <52C4C216.3070607@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.25.179] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014/1/11 0:02, Vegard Nossum wrote: > On 2 January 2014 02:34, Xishi Qiu wrote: >> On 2013/12/31 18:12, Vegard Nossum wrote: >>> On 31 December 2013 09:32, Xishi Qiu wrote: >>>> Add a new command-line kmemcheck value: kmemcheck=3 (disable the feature), >>>> this is the same effect as CONFIG_KMEMCHECK disabled. >>>> After doing this, we can enable/disable kmemcheck feature in one vmlinux. >>> >>> Could you please explain what exactly the difference is between the >>> existing kmemcheck=0 parameter and the new kmemcheck=3? >> >> kmemcheck=0: enable kmemcheck feature, but don't check the memory. >> and the OS use only one cpu.(setup_max_cpus = 1) >> kmemcheck=3: disable kmemcheck feature. >> this is the same effect as CONFIG_KMEMCHECK disabled. >> OS will use cpus as many as possible. >> > > I see. In that case, I think it's better to allow all the CPUs to keep > running while kmemcheck is disabled with kmemcheck=0 boot parameter, > and offline them when/if kmemcheck is reenabled via > /proc/sys/kernel/kmemcheck. > > > Vegard > > Hi Vegard, In some scenes, user want to check memory dynamicly, this "dynamically" means we can turn on/off the feature at boottime, not runtime. Without this patch, if user want to use this feature, he should change config and build the kernel, then reboot. This is impossilbe if user has no kernel code or he don't know how to build the kernel. boottime: kmemcheck=0/1/2/3 (command-line) runtime: kmemcheck=0/1/2 (/proc/sys/kernel/kmemcheck) The main different between kmemcheck=0 and 3 is the used memory. Kmemcheck will use about twice as much memory as normal. Thanks, Xishi Qiu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/