Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755021AbaAVBfX (ORCPT ); Tue, 21 Jan 2014 20:35:23 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:35033 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754281AbaAVBfS (ORCPT ); Tue, 21 Jan 2014 20:35:18 -0500 Date: Tue, 21 Jan 2014 20:35:12 -0500 From: Matt Porter To: Olof Johansson Cc: Sherman Yin , Mark Brown , Heiko =?iso-8859-1?Q?St=FCbner?= , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Christian Daudt , Russell King , Linus Walleij , Grant Likely , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , bcm-kernel-feedback-list@broadcom.com, "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] pinctrl: Rename Broadcom Capri pinctrl driver Message-ID: <20140122013512.GT31176@beef> References: <1390343886-25852-1-git-send-email-syin@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2014 at 04:59:35PM -0800, Olof Johansson wrote: > Hi, > > > On Tue, Jan 21, 2014 at 2:38 PM, Sherman Yin wrote: > > To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl > > driver and its related CONFIG option are renamed to bcm281xx. > > > > Devicetree compatible string and binding documentation use > > "brcm,bcm11351-pinctrl" to match the machine binding here: > > Documentation/devicetree/bindings/arm/bcm/bcm11351.txt > > > > This driver supports pinctrl on BCM11130, BCM11140, BCM11351, BCM28145 > > and BCM28155 SoCs. > > > > Signed-off-by: Sherman Yin > > Reviewed-by: Matt Porter > > --- > > ...capri-pinctrl.txt => brcm,bcm11351-pinctrl.txt} | 8 +- > > arch/arm/boot/dts/bcm11351.dtsi | 2 +- > > arch/arm/configs/bcm_defconfig | 2 +- > > drivers/pinctrl/Kconfig | 8 +- > > drivers/pinctrl/Makefile | 2 +- > > .../{pinctrl-capri.c => pinctrl-bcm281xx.c} | 1521 ++++++++++---------- > > 6 files changed, 775 insertions(+), 768 deletions(-) > > rename Documentation/devicetree/bindings/pinctrl/{brcm,capri-pinctrl.txt => brcm,bcm11351-pinctrl.txt} (98%) > > rename drivers/pinctrl/{pinctrl-capri.c => pinctrl-bcm281xx.c} (25%) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,capri-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/brcm,bcm11351-pinctrl.txt > > similarity index 98% > > rename from Documentation/devicetree/bindings/pinctrl/brcm,capri-pinctrl.txt > > rename to Documentation/devicetree/bindings/pinctrl/brcm,bcm11351-pinctrl.txt > > index 9e9e9ef..c119deb 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/brcm,capri-pinctrl.txt > > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm11351-pinctrl.txt > > @@ -1,4 +1,4 @@ > > -Broadcom Capri Pin Controller > > +Broadcom BCM281xx Pin Controller > > > > This is a pin controller for the Broadcom BCM281xx SoC family, which includes > > BCM11130, BCM11140, BCM11351, BCM28145, and BCM28155 SoCs. > > @@ -7,14 +7,14 @@ BCM11130, BCM11140, BCM11351, BCM28145, and BCM28155 SoCs. > > > > Required Properties: > > > > -- compatible: Must be "brcm,capri-pinctrl". > > +- compatible: Must be "brcm,bcm11351-pinctrl" > > Since the original binding is queued for 3.14 (I believe?), if this > rename isn't merged for 3.14 then you will still need to accept the > old compatible string (binding). You can document it as deprecated, > but the driver needs to still probe with it. Linus had mentioned that he could take a rename in 3.14-rc for this driver which is really what we had in mind here. Since the binding doesn't become stable until 3.14 is actually released I was under the impression that this is ok without keeping a deprecated compatible string. I notice that Tomasz had comments about this type of situation in http://www.spinics.net/lists/devicetree/msg18010.html -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/