Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755372AbaAVOD1 (ORCPT ); Wed, 22 Jan 2014 09:03:27 -0500 Received: from mail-oa0-f51.google.com ([209.85.219.51]:51358 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755209AbaAVODY (ORCPT ); Wed, 22 Jan 2014 09:03:24 -0500 MIME-Version: 1.0 In-Reply-To: <20140122130211.GB1132@krava.brq.redhat.com> References: <20140122130211.GB1132@krava.brq.redhat.com> Date: Wed, 22 Jan 2014 09:03:21 -0500 X-Google-Sender-Auth: SnlHoBaL-x9iPuWhj9Z5y29PvoI Message-ID: Subject: Re: [PATCH] perf tests: Add install prefix tests From: Josh Boyer To: Jiri Olsa Cc: Ingo Molnar , Steven Rostedt , Arnaldo Carvalho de Melo , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 22, 2014 at 8:02 AM, Jiri Olsa wrote: > On Tue, Jan 21, 2014 at 07:58:41PM -0500, Josh Boyer wrote: >> On Tue, Jan 21, 2014 at 3:02 PM, Josh Boyer wrote: >> > Hi All, >> > >> > I went to build Linux v3.13-737-g7fe67a1 in Fedora this morning and it >> > resulted in RPM complaining that the perf and perf.so binaries had >> > > SNIP > >> I'm not sure why DESTDIR is included in the -DPLUGIN_DIR definition in >> tools/lib/traceevent/Makefile, nor why $(prefix) is in plugindir_SQ in >> tools/perf/config/Makefile. >> >> josh >> >> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile >> index 56d52a3..005c9cc 100644 >> --- a/tools/lib/traceevent/Makefile >> +++ b/tools/lib/traceevent/Makefile >> @@ -63,7 +63,7 @@ endif >> endif >> >> ifeq ($(set_plugin_dir),1) >> -PLUGIN_DIR = -DPLUGIN_DIR="$(DESTDIR)/$(plugin_dir)" >> +PLUGIN_DIR = -DPLUGIN_DIR="$(plugin_dir)" >> PLUGIN_DIR_SQ = '$(subst ','\'',$(PLUGIN_DIR))' > > hi, > this one needs to stay, otherwise perf have wrong path > to load plugins from.. Hm. Are you sure? I believe I tested with just the $(prefix) removed below and it still failed the RPM build. If DESTDIR is included in what is passed as DPLUGIN_DIR, it will include the buildroot path in the binaries, but when the RPM is installed it does not install to the buildroot path. E.g. you will have: -DPLUGIN_DIR="/home/jwboyer/rpmbuild/BUILDROOT/kernel-3.14.0-0.rc0.git1.1.fc21.x86_64//usr/lib64/traceevent/plugins" but the plugins will be installed to /usr/lib64/traceevent/plugins by RPM. I'll try again with just the libdir fix, but I'm fairly sure what I've said above is correct. At least in terms of how RPMs are built. josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/