Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755428AbaAVSBB (ORCPT ); Wed, 22 Jan 2014 13:01:01 -0500 Received: from mail-wg0-f50.google.com ([74.125.82.50]:45837 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752409AbaAVSA7 (ORCPT ); Wed, 22 Jan 2014 13:00:59 -0500 Message-ID: <52E00751.5010309@dev.mellanox.co.il> Date: Wed, 22 Jan 2014 20:00:49 +0200 From: Sagi Grimberg User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "Nicholas A. Bellinger" CC: "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , "Martin K. Petersen" , Christoph Hellwig , Hannes Reinecke , Sagi Grimberg , Or Gerlitz , Roland Dreier Subject: Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb References: <1390099480-29013-1-git-send-email-nab@daterainc.com> <1390099480-29013-4-git-send-email-nab@daterainc.com> <52DBBA69.4040800@dev.mellanox.co.il> <1390344494.5567.792.camel@haakon3.risingtidesystems.com> In-Reply-To: <1390344494.5567.792.camel@haakon3.risingtidesystems.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/2014 12:48 AM, Nicholas A. Bellinger wrote: > + cmd->prot_handover = PROT_SEPERATED; >> I know that we are not planning to support interleaved mode at the >> moment, But I think >> that the protection handover type is the backstore preference and should >> be taken from se_dev. >> But it is not that important for now... >> > Yeah, I figured since the RDMA pieces needed the handover type defined > in some form, it made sense to include PROT_SEPERATED hardcoded here, > but stopped short of adding se_dev->prot_handler for the first round > merge. > > --nab > Actually they don't, I just added them in iSER code to demonstrate the HW ability. If we are not planning to support that (although as MKP mentioned it might be useful in some cases), you can remove that for now and we can add it in the future - iSER can ignore it for now (I'll refactor the patches). Sagi. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/