Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753546AbaAVViM (ORCPT ); Wed, 22 Jan 2014 16:38:12 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:39871 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753486AbaAVViH (ORCPT ); Wed, 22 Jan 2014 16:38:07 -0500 MIME-Version: 1.0 In-Reply-To: <1390272375-28728-1-git-send-email-wangyijing@huawei.com> References: <1390272375-28728-1-git-send-email-wangyijing@huawei.com> From: Bjorn Helgaas Date: Wed, 22 Jan 2014 14:37:45 -0700 Message-ID: Subject: Re: [PATCH v4] ACPI: Fix acpi_evaluate_object() return value check To: Yijing Wang Cc: "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, DRI mailing list , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Greg Kroah-Hartman , Dave Airlie , Hanjun Guo Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2014 at 7:46 PM, Yijing Wang wrote: > Since acpi_evaluate_object() returns acpi_status and not plain int, > ACPI_FAILURE() should be used for checking its return value. > > Reviewed-by: Jani Nikula > Signed-off-by: Yijing Wang > --- > v3->v4: Fix spell error, add Jani Nikula reviewed-by. > v2->v3: Fix compile error pointed out by Hanjun. > v1->v2: Add CC to related subsystem MAINTAINERS > --- > drivers/gpu/drm/i915/intel_acpi.c | 24 ++++++++++++++---------- > drivers/gpu/drm/nouveau/core/subdev/mxm/base.c | 9 +++++---- > drivers/gpu/drm/nouveau/nouveau_acpi.c | 23 +++++++++++++---------- > drivers/pci/pci-label.c | 9 ++++++--- For the drivers/pci/pci-label.c part, Acked-by: Bjorn Helgaas > + status = acpi_evaluate_object(handle, "_DSM", &input, &output); > + if (ACPI_FAILURE(status)) { > + DRM_DEBUG_DRIVER("failed to evaluate _DSM: %s\n", > + acpi_format_exception(status)); It's too bad there isn't an easy way to produce more informative error messages, e.g., by including a namespace path or something. A message like: failed to evaluate _DSM: A requested entity is not found is only useful if there's enough context to figure out what's going on. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/