Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753081AbaAWFnS (ORCPT ); Thu, 23 Jan 2014 00:43:18 -0500 Received: from mail-ve0-f176.google.com ([209.85.128.176]:58260 "EHLO mail-ve0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbaAWFnP convert rfc822-to-8bit (ORCPT ); Thu, 23 Jan 2014 00:43:15 -0500 MIME-Version: 1.0 In-Reply-To: References: <1388400186-22045-1-git-send-email-amit.grover@samsung.com> From: Prabhakar Lad Date: Thu, 23 Jan 2014 11:12:54 +0530 Message-ID: Subject: Re: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks To: swaminathan Cc: Amit Grover , linux-media , LDOC , LKML , LAK , linux-samsung-soc@vger.kernel.org, Rob Landley , Kyungmin Park , Kamil Debski , Jeongtae Park , anatol.pomozov@gmail.com, Andrey Smirnov , Hans Verkuil , Hans Verkuil , Sylwester Nawrocki , austin.lobo@samsung.com, jmccrohan@gmail.com, arun.kk@samsung.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Swaminathan, On Thu, Jan 23, 2014 at 10:49 AM, swaminathan wrote: > Hi All, > Is there any review Comments for the patch "[PATCH] [media] s5p-mfc: Add > Horizontal and Vertical search range for Video Macro Blocks" > posted on 30-Dec-2013 ? > > Just a side note, please don?t top post and always reply as plain text. [Snip] > Subject: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range > for Video Macro Blocks > > >> This patch adds Controls to set Horizontal and Vertical search range >> for Motion Estimation block for Samsung MFC video Encoders. >> >> Signed-off-by: Swami Nathan >> Signed-off-by: Amit Grover >> --- >> Documentation/DocBook/media/v4l/controls.xml | 14 +++++++++++++ >> drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 2 ++ >> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 24 >> +++++++++++++++++++++++ >> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 8 ++------ >> drivers/media/v4l2-core/v4l2-ctrls.c | 14 +++++++++++++ >> include/uapi/linux/v4l2-controls.h | 2 ++ >> 6 files changed, 58 insertions(+), 6 deletions(-) >> This patch from the outset looks OK, but you need to split up into two, first adding a v4l control and second one using it up in the driver. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/