Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbaAWHdu (ORCPT ); Thu, 23 Jan 2014 02:33:50 -0500 Received: from mail-oa0-f48.google.com ([209.85.219.48]:49855 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217AbaAWHds (ORCPT ); Thu, 23 Jan 2014 02:33:48 -0500 MIME-Version: 1.0 In-Reply-To: <1389886665-32076-1-git-send-email-srinivas.kandagatla@st.com> References: <1389886545-31498-1-git-send-email-srinivas.kandagatla@st.com> <1389886665-32076-1-git-send-email-srinivas.kandagatla@st.com> Date: Thu, 23 Jan 2014 08:33:48 +0100 Message-ID: Subject: Re: [PATCH v2 4/4] ARM:STi: STiH415: Add interrupt support for pin controller From: Linus Walleij To: Srinivas KANDAGATLA Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Russell King , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 16, 2014 at 4:37 PM, wrote: > From: Srinivas Kandagatla > > This patch adds interrupt support for STiH415 pin controllers. > > Signed-off-by: Srinivas Kandagatla Acked-by: Linus Walleij Merge this through ARM SoC. > + reg = <0xfe61f080 0x4>; > + reg-names = "irqmux"; Aha so that is how it looks when you handle the separate mux reg, well I can't think of anything better and this works fine for me. The alternative would be to have a syscon thing using regmap such as drivers/mfd/syscon.c but I really cannot decide between these two design patterns for odd registers. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/