Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932353AbaAWTwR (ORCPT ); Thu, 23 Jan 2014 14:52:17 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:34086 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713AbaAWTwN (ORCPT ); Thu, 23 Jan 2014 14:52:13 -0500 Date: Thu, 23 Jan 2014 19:51:44 +0000 From: Alan Cox To: Mark Brown Cc: Tomasz Figa , Tushar Behera , Russell King - ARM Linux , lkml , linux-serial , linux-samsung-soc , jslaby , Greg Kroah-Hartman , Ben Dooks Subject: Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe Message-ID: <20140123195144.2d3aa44d@www.etchedpixels.co.uk> In-Reply-To: <20140123193633.GG11727@sirena.org.uk> References: <1390208555-27770-1-git-send-email-tushar.behera@linaro.org> <1390208555-27770-2-git-send-email-tushar.behera@linaro.org> <20140120100530.GY15937@n2100.arm.linux.org.uk> <20140123180423.1a62611a@www.etchedpixels.co.uk> <20140123184022.GC11727@sirena.org.uk> <52E163DC.1090002@samsung.com> <20140123193633.GG11727@sirena.org.uk> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jan 2014 19:36:33 +0000 Mark Brown wrote: > On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: > > On 23.01.2014 19:40, Mark Brown wrote: > > > >We'd need to leave it user selectable rather than enabling it for ARM, > > >the whole reason this got noticed is that people are trying to build > > >kernels that support a wider range of devices for ARM. > > > What about making it depend on !MULTIPLATFORM and enabled by default? > > That'd work, but if we're doing that then substituting in the dynamic > assignment only when we hit a collision seems smoother and more general. > Or we could just make the core ignore all hard coded numbers if this is > set rather than putting ifdefs in the drivers. That strikes me as rather more risky. We can propogate it through the drivers as we are sure it is safe to do so on that platform and encourage driver authors to migrate. Better than a "big bang" and the inevitable fallout. We do want it user selectable, because we want people to leave it off unless they have a need for it - that then becomes a path towards eventually getting rid of them static identifiers for good. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/