Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753528AbaAWUGL (ORCPT ); Thu, 23 Jan 2014 15:06:11 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:41167 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751967AbaAWUGE (ORCPT ); Thu, 23 Jan 2014 15:06:04 -0500 Date: Thu, 23 Jan 2014 15:06:02 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Valentina Manea cc: Greg KH , Anthony Foiani , , , , , , , "Linux Kernel Community @ ROSEdu" , , , Subject: Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jan 2014, Valentina Manea wrote: > 1. The usbip_status file is no longer created for interface 0, but for > the whole device (such as > /sys/devices/pci0000:00/0000:00:01.2/usb1/1-1/usbip_status). > 2. Per interface information, such as interface class or protocol, is > no longer sent/received. Only device specific information is > transmitted. > 3. Since the driver was moved one level below in the USB architecture, > there is no need to bind/unbind each interface, just the device as a > whole. If you don't bind the interfaces, they will naturally bind to their normal drivers on the host. You probably don't want that to happen. (Although, at the moment, I don't see how you can prevent it.) Also, in your patch, stub_probe() calls usb_choose_configuration(). Shouldn't that be done by the client, since the client now has access to the entire device? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/