Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbaAXHEO (ORCPT ); Fri, 24 Jan 2014 02:04:14 -0500 Received: from mail-ig0-f176.google.com ([209.85.213.176]:43272 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923AbaAXHEM (ORCPT ); Fri, 24 Jan 2014 02:04:12 -0500 MIME-Version: 1.0 In-Reply-To: <52E20E98.7010703@ti.com> References: <52E19C7D.7050603@intel.com> <52E20A56.1000507@ti.com> <52E20E98.7010703@ti.com> Date: Thu, 23 Jan 2014 23:04:12 -0800 X-Google-Sender-Auth: 0IUmJ1_zG-4Yj5A_mk2gnpX1s9U Message-ID: Subject: Re: Panic on 8-node system in memblock_virt_alloc_try_nid() From: Yinghai Lu To: Santosh Shilimkar Cc: Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Grygorii Strashko , Linux-MM , LKML , Tejun Heo , Andrew Morton Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2014 at 10:56 PM, Santosh Shilimkar wrote: > On Friday 24 January 2014 01:38 AM, Santosh Shilimkar wrote: > The patch which is now commit 457ff1d {lib/swiotlb.c: use > memblock apis for early memory allocations} was the breaking the > boot on Andrew's machine. Now if I look back the patch, based on your > above description, I believe below hunk waS/is the culprit. > > @@ -172,8 +172,9 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) > /* > * Get the overflow emergency buffer > */ > - v_overflow_buffer = alloc_bootmem_low_pages_nopanic( > - PAGE_ALIGN(io_tlb_overflow)); > + v_overflow_buffer = memblock_virt_alloc_nopanic( > + PAGE_ALIGN(io_tlb_overflow), > + PAGE_SIZE); > if (!v_overflow_buffer) > return -ENOMEM; > > > Looks like 'v_overflow_buffer' must be allocated from low memory in this > case. Is that correct ? yes. but should the change like following commit 457ff1de2d247d9b8917c4664c2325321a35e313 Author: Santosh Shilimkar Date: Tue Jan 21 15:50:30 2014 -0800 lib/swiotlb.c: use memblock apis for early memory allocations @@ -215,13 +220,13 @@ swiotlb_init(int verbose) bytes = io_tlb_nslabs << IO_TLB_SHIFT; /* Get IO TLB memory from the low pages */ - vstart = alloc_bootmem_low_pages_nopanic(PAGE_ALIGN(bytes)); + vstart = memblock_virt_alloc_nopanic(PAGE_ALIGN(bytes), PAGE_SIZE); if (vstart && !swiotlb_init_with_tbl(vstart, io_tlb_nslabs, verbose)) return; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/