Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751774AbaAXISl (ORCPT ); Fri, 24 Jan 2014 03:18:41 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:51632 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbaAXISj (ORCPT ); Fri, 24 Jan 2014 03:18:39 -0500 Date: Fri, 24 Jan 2014 00:18:38 -0800 (PST) Message-ID: <871tzxg5d1.wl%kuninori.morimoto.gx@gmail.com> From: Kuninori Morimoto To: Geert Uytterhoeven Cc: Vinod Koul , Morimoto , Linux-SH , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver In-Reply-To: References: <878uu6gle8.wl%kuninori.morimoto.gx@gmail.com> User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert Thank you for your review > > --- a/drivers/dma/sh/Kconfig > > +++ b/drivers/dma/sh/Kconfig > > @@ -29,6 +29,12 @@ config RCAR_HPB_DMAE > > help > > Enable support for the Renesas R-Car series DMA controllers. > > > > +config RCAR_AUDMAC_PP > > + tristate "Renesas R-Car Audio DMAC Peripheral Peripheral support" > > double "Peripheral" Unfortunately (?) "Audio DMAC Peripheral Peripheral" (= double Peripheral) is the formal name > > + for(i = 0; i < 1024; i++) { > > Missing space between "for" and "(" (have you run checkpatch.pl?) > > What's a typical value of i when leaving the loop? Oops, this is my fault. I will fix in v2 > > +static struct audmapp_slave_config * > > +audmapp_find_slave(struct audmapp_chan *auchan, int slave_id) > > +{ > > + struct audmapp_device *audev = to_dev(auchan); > > + struct audmapp_pdata *pdata = audev->pdata; > > + struct audmapp_slave_config *cfg; > > + int i; > > unsigned int > > > + > > + if (slave_id >= AUDMAPP_SLAVE_NUMBER) > > So slave_id should be unsigned int, too, and AUDMAPP_SLAVE_NUMBER > too ("29U"). Hmm... This driver is called from shdma-base.c. And shdmac.c/sudmac.c/rcar-hpbdmac.c are same style. 1) this "slave_id" came from shdma_ops::set_slave and, it is using "int" 2) above drivers have same xxx_find_slave(), they are using "int". (this driver is based on that) What should I do ? > > + if (*len > (size_t)AUDMAPP_LEN_MAX) > > I think you can get rid of the cast by adding a "U" suffix to one of > the constants in the definition of AUDMAPP_LEN_MAX. > > > + *len = (size_t)AUDMAPP_LEN_MAX; > > The cast is not needed (I think even without the change above). I will fixup these in v2 Thank you Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/