Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751736AbaAXI6s (ORCPT ); Fri, 24 Jan 2014 03:58:48 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:61374 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbaAXI6r (ORCPT ); Fri, 24 Jan 2014 03:58:47 -0500 Date: Fri, 24 Jan 2014 00:58:46 -0800 (PST) Message-ID: <87zjmleoxp.wl%kuninori.morimoto.gx@gmail.com> From: Kuninori Morimoto To: Geert Uytterhoeven Cc: Vinod Koul , Morimoto , Linux-SH , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver In-Reply-To: References: <878uu6gle8.wl%kuninori.morimoto.gx@gmail.com> <871tzxg5d1.wl%kuninori.morimoto.gx@gmail.com> User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert > > This driver is called from shdma-base.c. > > And shdmac.c/sudmac.c/rcar-hpbdmac.c are same style. > > > > 1) this "slave_id" came from shdma_ops::set_slave > > and, it is using "int" > > 2) above drivers have same xxx_find_slave(), > > they are using "int". > > (this driver is based on that) > > > > What should I do ? > > OK, then you should keep using int, and change the test to: > > if (slave_id < 0 || slave_id >= AUDMAPP_SLAVE_NUMBER) I see Thank you Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/