Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752288AbaAXKdm (ORCPT ); Fri, 24 Jan 2014 05:33:42 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:36655 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbaAXKdg (ORCPT ); Fri, 24 Jan 2014 05:33:36 -0500 Date: Fri, 24 Jan 2014 02:33:27 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Li Zefan cc: Viresh Kumar , mingo@kernel.org, peterz@infradead.org, linaro-kernel@lists.linaro.org, patches@linaro.org, linux-kernel@vger.kernel.org, Cgroups , Tejun Heo Subject: Re: [PATCH] cpusets: Allocate heap only when required In-Reply-To: <52E1C8BD.2010500@huawei.com> Message-ID: References: <8622e93b9c49c66ffdc9ef0aa8371c322718edd5.1390475530.git.viresh.kumar@linaro.org> <52E1C8BD.2010500@huawei.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jan 2014, Li Zefan wrote: > >> update_flag() routine uses heap only when spread_flag_changed is true. Otherwise > >> heap isn't used, but is allocated and freed unnecessarily. > >> > > but harmless > It's not harmless, if heap_init() fails with -ENOMEM then the write fails even though it may not be for memory_spread_page or memory_spread_slab, which is the minority of the callers of this function. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/