Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752388AbaAXKgg (ORCPT ); Fri, 24 Jan 2014 05:36:36 -0500 Received: from mail-qa0-f48.google.com ([209.85.216.48]:60155 "EHLO mail-qa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbaAXKgf (ORCPT ); Fri, 24 Jan 2014 05:36:35 -0500 Date: Fri, 24 Jan 2014 05:36:31 -0500 From: Tejun Heo To: David Rientjes Cc: Li Zefan , Viresh Kumar , mingo@kernel.org, peterz@infradead.org, linaro-kernel@lists.linaro.org, patches@linaro.org, linux-kernel@vger.kernel.org, Cgroups Subject: Re: [PATCH] cpusets: Allocate heap only when required Message-ID: <20140124103631.GB4101@htj.dyndns.org> References: <8622e93b9c49c66ffdc9ef0aa8371c322718edd5.1390475530.git.viresh.kumar@linaro.org> <52E1C8BD.2010500@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 24, 2014 at 02:33:27AM -0800, David Rientjes wrote: > It's not harmless, if heap_init() fails with -ENOMEM then the write fails > even though it may not be for memory_spread_page or memory_spread_slab, > which is the minority of the callers of this function. And depending on details like that would actually be more harmful. Please remember that all writes through cgroupfs may fail under very high memory pressure. There's no "this specific set of writes to this specific knob isn't affected by memory pressure" guarantee. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/