Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752544AbaAXLT7 (ORCPT ); Fri, 24 Jan 2014 06:19:59 -0500 Received: from www.linutronix.de ([62.245.132.108]:51461 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbaAXLT5 (ORCPT ); Fri, 24 Jan 2014 06:19:57 -0500 Message-ID: <52E24C58.2000205@linutronix.de> Date: Fri, 24 Jan 2014 12:19:52 +0100 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Steven Rostedt CC: Mike Galbraith , linux-rt-users , LKML , Thomas Gleixner , John Kacur Subject: Re: [ANNOUNCE] 3.12.6-rt9 References: <20131223225017.GA8623@linutronix.de> <1387900067.5490.33.camel@marge.simpson.net> <20140117170052.GF5785@linutronix.de> <1390014929.5444.38.camel@marge.simpson.net> <20140120211736.0c97418a@gandalf.local.home> In-Reply-To: <20140120211736.0c97418a@gandalf.local.home> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2014 03:17 AM, Steven Rostedt wrote: > Signed-off-by: Steven Rostedt > > diff --git a/kernel/timer.c b/kernel/timer.c > index 46467be..8212c10 100644 > --- a/kernel/timer.c > +++ b/kernel/timer.c > @@ -1464,13 +1464,11 @@ void run_local_timers(void) > raise_softirq(TIMER_SOFTIRQ); > return; > } > - if (!base->active_timers) > - goto out; > > /* Check whether the next pending timer has expired */ > if (time_before_eq(base->next_timer, jiffies)) > raise_softirq(TIMER_SOFTIRQ); Hmmm. If active_timers is 0 and "time_before_eq(base->next_timer, jiffies))" is true than that timer should have been initialized with init_timer_deferrable() or we have a serious bug here where active_timers isn't properly synchronized anymore. Now. If there is really just a deferrable timer that expired and nothing else then this would explain it. > -out: > + > rt_spin_unlock_after_trylock_in_irq(&base->lock); > > } Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/