Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752566AbaAXSvm (ORCPT ); Fri, 24 Jan 2014 13:51:42 -0500 Received: from mail-ie0-f180.google.com ([209.85.223.180]:38930 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbaAXSvl (ORCPT ); Fri, 24 Jan 2014 13:51:41 -0500 MIME-Version: 1.0 In-Reply-To: <52E2B431.5090705@intel.com> References: <52E19C7D.7050603@intel.com> <52E28067.1060507@intel.com> <52E2AC5A.3000005@intel.com> <52E2AEA3.2020907@intel.com> <52E2B431.5090705@intel.com> Date: Fri, 24 Jan 2014 10:51:40 -0800 X-Google-Sender-Auth: R5eJSm959PEKckHzgG_ZeGdiHAk Message-ID: Subject: Re: Panic on 8-node system in memblock_virt_alloc_try_nid() From: Yinghai Lu To: Dave Hansen Cc: "H. Peter Anvin" , Ingo Molnar , Grygorii Strashko , Linux-MM , LKML , Santosh Shilimkar , Tejun Heo , Andrew Morton Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 24, 2014 at 10:42 AM, Dave Hansen wrote: > On 01/24/2014 10:24 AM, Yinghai Lu wrote: >> On Fri, Jan 24, 2014 at 10:19 AM, Dave Hansen wrote: >>> FWIW, I did turn of memblock=debug. It eventually booted, but >>> slooooooooooowly. >> >> then that is not a problem, as you are using 4k page mapping only. >> and that printout is too spew... > > This means that, essentially, memblock=debug and > KMEMCHECK/DEBUG_PAGEALLOC can't be used together. That's a shame > because my DEBUG_PAGEALLOC config *broke* this code a few months ago, > right? Oh well. should only be broken when MOVABLE_NODE is enabled on big system. > >>> How many problems in this code are we tracking, btw? This is at least >>> 3, right? >> >> two problems: >> 1. big numa system. >> 2. Andrew's system with swiotlb. > > Can I ask politely for some more caution on your part in this area? > This is two consecutive kernels where this code has broken my system. I agree, the code get messy as now we have top_down and bottom up mapping for different configuration. I already tried hard to make parsing srat early solution instead that split. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/