Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753086AbaAXVlj (ORCPT ); Fri, 24 Jan 2014 16:41:39 -0500 Received: from top.free-electrons.com ([176.31.233.9]:44185 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752486AbaAXVlg (ORCPT ); Fri, 24 Jan 2014 16:41:36 -0500 Date: Fri, 24 Jan 2014 18:41:37 -0300 From: Ezequiel Garcia To: Sebastian Hesselbarth Cc: Thomas Gleixner , Jason Cooper , Andrew Lunn , Gregory Clement , Jason Gunthorpe , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] irqchip: orion: clear bridge cause register on init Message-ID: <20140124211528.GA14012@localhost> References: <1390516686-2224-1-git-send-email-sebastian.hesselbarth@gmail.com> <1390516686-2224-2-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1390516686-2224-2-git-send-email-sebastian.hesselbarth@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2014 at 11:38:04PM +0100, Sebastian Hesselbarth wrote: > It is good practice to mask and clear pending irqs on init. We already > mask all irqs, so also clear the bridge irq cause register. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: Jason Gunthorpe > Cc: Ezequiel Garcia > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/irqchip/irq-orion.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-orion.c b/drivers/irqchip/irq-orion.c > index e51d40031884..4137c3d15284 100644 > --- a/drivers/irqchip/irq-orion.c > +++ b/drivers/irqchip/irq-orion.c > @@ -180,8 +180,9 @@ static int __init orion_bridge_irq_init(struct device_node *np, > gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit; > gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit; > > - /* mask all interrupts */ > + /* mask and clear all interrupts */ > writel(0, gc->reg_base + ORION_BRIDGE_IRQ_MASK); > + writel(0, gc->reg_base + ORION_BRIDGE_IRQ_CAUSE); > This looks a bit bogus to me, now that we are clearing the cause upon irq_startup(). Don't have a strong opinion, it's just that I fail to see why we'd want or need this change... -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/