Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751433AbaAYFiM (ORCPT ); Sat, 25 Jan 2014 00:38:12 -0500 Received: from top.free-electrons.com ([176.31.233.9]:44621 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750854AbaAYFiJ (ORCPT ); Sat, 25 Jan 2014 00:38:09 -0500 Date: Sat, 25 Jan 2014 02:38:17 -0300 From: Ezequiel Garcia To: Fabian Frederick Cc: linux-mtd@lists.infradead.org, akpm@linux-foundation.org, rdunlap@infradead.org, joern@lazybastard.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mtd: block2mtd: Add mutex_destroy Message-ID: <20140125053816.GB24609@localhost> References: <20140123205147.943d63fecf3140aa6cc76994@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140123205147.943d63fecf3140aa6cc76994@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2014 at 08:51:47PM +0100, Fabian Frederick wrote: > mutex_destroy added on each device in block2mtd_exit and add_device failure > > Signed-off-by: Fabian Frederick > --- > drivers/mtd/devices/block2mtd.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c > index 0efee5b..8071596 100644 > --- a/drivers/mtd/devices/block2mtd.c > +++ b/drivers/mtd/devices/block2mtd.c > @@ -240,14 +240,14 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size) > > if (IS_ERR(bdev)) { > pr_err("error: cannot open device %s\n", devname); > - goto devinit_err; > + goto devinit_err1; Ah, this one commit looks good, but the naming of the labels doesn't. Instead, you should use a name describing what the error path does, such as "err_free_block2mtd" and "err_destroy_mutex" or something like that. We have a language full of words with meaning, so it's shame to use dumb numbers :-) -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/