Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752264AbaAYTG1 (ORCPT ); Sat, 25 Jan 2014 14:06:27 -0500 Received: from multi.imgtec.com ([194.200.65.239]:58934 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbaAYTGZ (ORCPT ); Sat, 25 Jan 2014 14:06:25 -0500 From: Raghu Gandham To: , , , , CC: Raghu Gandham Subject: [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions. Date: Sat, 25 Jan 2014 11:01:54 -0800 Message-ID: <1390676514-30880-1-git-send-email-raghu.gandham@imgtec.com> X-Mailer: git-send-email 1.8.5.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.67.8] X-SEF-Processed: 7_3_0_01192__2014_01_25_19_06_23 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The standard IO regions are already reserved by the platform code on most MIPS devices(malta, cobalt, sni). The Commit 197a1e96c8be5b6005145af3a4c0e45e2d651444 ("Input: i8042-io - fix up region handling on MIPS") introduced a bug on these MIPS platforms causing i8042 driver to fail when trying to reserve IO ports. Prior to the above mentioned commit request_region is skipped on MIPS but release_region is called. This patch reverts commit 197a1e96c8be5b6005145af3a4c0e45e2d651444 and also avoids calling release_region for MIPS. Signed-off-by: Raghu Gandham Reviewed-by: Steven J. Hill --- drivers/input/serio/i8042-io.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/serio/i8042-io.h b/drivers/input/serio/i8042-io.h index a5eed2a..a09bb72 100644 --- a/drivers/input/serio/i8042-io.h +++ b/drivers/input/serio/i8042-io.h @@ -76,7 +76,7 @@ static inline int i8042_platform_init(void) if (check_legacy_ioport(I8042_DATA_REG)) return -ENODEV; #endif -#if !defined(__sh__) && !defined(__alpha__) +#if !defined(__sh__) && !defined(__alpha__) && !defined(__mips__) if (!request_region(I8042_DATA_REG, 16, "i8042")) return -EBUSY; #endif @@ -87,7 +87,7 @@ static inline int i8042_platform_init(void) static inline void i8042_platform_exit(void) { -#if !defined(__sh__) && !defined(__alpha__) +#if !defined(__sh__) && !defined(__alpha__) && !defined(__mips__) release_region(I8042_DATA_REG, 16); #endif } -- 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/