Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbaAYVHH (ORCPT ); Sat, 25 Jan 2014 16:07:07 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:43872 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752112AbaAYVHF (ORCPT ); Sat, 25 Jan 2014 16:07:05 -0500 Date: Sat, 25 Jan 2014 13:07:00 -0800 From: Matt Wilson To: Ian Campbell Cc: Matt Wilson , linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, Matt Rushton , David Vrabel , Anthony Liguori , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used Message-ID: <20140125210659.GA15756@u109add4315675089e695.ant.amazon.com> References: <1390505326-9368-1-git-send-email-msw@linux.com> <1390555293.2124.6.camel@kazak.uk.xensource.com> <1390577782.13513.8.camel@kazak.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1390577782.13513.8.camel@kazak.uk.xensource.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 24, 2014 at 03:36:22PM +0000, Ian Campbell wrote: > On Fri, 2014-01-24 at 09:21 +0000, Ian Campbell wrote: > > On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: > > > From: Matt Rushton > > > > > > Currently shrink_free_pagepool() is called before the pages used for > > > persistent grants are released via free_persistent_gnts(). This > > > results in a memory leak when a VBD that uses persistent grants is > > > torn down. > > > > This may well be the explanation for the memory leak I was observing on > > ARM last night. I'll give it a go and let you know. > > Results are a bit inconclusive unfortunately, it seems like I am seeing > some other leak too (or instead). > > Totally unscientifically it does seem to be leaking more slowly than > before, so perhaps this patch has helped, but nothing conclusive I'm > afraid. Testing here looks good. I don't know if perhaps something else is going on with ARM... > I don't think that quite qualifies for a Tested-by though, sorry. How about an Acked-by? ;-) --msw > Ian. > > > > > > Cc: Konrad Rzeszutek Wilk > > > Cc: "Roger Pau Monn?" > > > Cc: Ian Campbell > > > Cc: David Vrabel > > > Cc: linux-kernel@vger.kernel.org > > > Cc: xen-devel@lists.xen.org > > > Cc: Anthony Liguori > > > Signed-off-by: Matt Rushton > > > Signed-off-by: Matt Wilson > > > --- > > > drivers/block/xen-blkback/blkback.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c > > > index 6620b73..30ef7b3 100644 > > > --- a/drivers/block/xen-blkback/blkback.c > > > +++ b/drivers/block/xen-blkback/blkback.c > > > @@ -625,9 +625,6 @@ purge_gnt_list: > > > print_stats(blkif); > > > } > > > > > > - /* Since we are shutting down remove all pages from the buffer */ > > > - shrink_free_pagepool(blkif, 0 /* All */); > > > - > > > /* Free all persistent grant pages */ > > > if (!RB_EMPTY_ROOT(&blkif->persistent_gnts)) > > > free_persistent_gnts(blkif, &blkif->persistent_gnts, > > > @@ -636,6 +633,9 @@ purge_gnt_list: > > > BUG_ON(!RB_EMPTY_ROOT(&blkif->persistent_gnts)); > > > blkif->persistent_gnt_c = 0; > > > > > > + /* Since we are shutting down remove all pages from the buffer */ > > > + shrink_free_pagepool(blkif, 0 /* All */); > > > + > > > if (log_stats) > > > print_stats(blkif); > > > > > > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/