Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753716AbaAYVxC (ORCPT ); Sat, 25 Jan 2014 16:53:02 -0500 Received: from yotta.elopez.com.ar ([31.220.24.173]:45493 "EHLO yotta.elopez.com.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbaAYVxB (ORCPT ); Sat, 25 Jan 2014 16:53:01 -0500 X-Greylist: delayed 1213 seconds by postgrey-1.27 at vger.kernel.org; Sat, 25 Jan 2014 16:53:00 EST Message-ID: <52E42D6A.5050508@elopez.com.ar> Date: Sat, 25 Jan 2014 18:32:26 -0300 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Sebastian Hesselbarth CC: Thomas Petazzoni , Andrew Lunn , Mike Turquette , Jason Cooper , linux-kernel@vger.kernel.org, Ezequiel Garcia , Gregory Clement , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/4] clk: mvebu: fix clk init order References: <1390673950-4521-1-git-send-email-sebastian.hesselbarth@gmail.com> In-Reply-To: <1390673950-4521-1-git-send-email-sebastian.hesselbarth@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sebastian, El 25/01/14 15:19, Sebastian Hesselbarth escribi?: > This patch set fixes clk init order that went upside-down with > v3.14. I haven't really investigated what caused this, but I assume > it is related with DT node reordering by addresses. The framework should be able to deal with unordered registration. I am not very familiar with the mvebu driver though, do you have a valid reason to require a specific order? > Anyway, with v3.14 for MVEBU SoCs, the clock gating driver gets > registered before core clocks driver. Unfortunately, we cannot > return -EPROBE_DEFER in drivers initialized by clk_of_init. Why would you need to do so? After a quick inspection on the code, I see you may have problems on mvebu_clk_gating_setup() when getting the default parent clock name, but I believe you could solve it in an easier way by using of_clk_get_parent_name(). Cheers, Emilio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/