Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbaAYW3v (ORCPT ); Sat, 25 Jan 2014 17:29:51 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:37990 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbaAYW3t (ORCPT ); Sat, 25 Jan 2014 17:29:49 -0500 Date: Sat, 25 Jan 2014 23:29:29 +0100 From: Pavel Machek To: Jenny TC Cc: linux-kernel@vger.kernel.org, Dmitry Eremin-Solenikov , Anton Vorontsov , Anton Vorontsov , Kim Milo , Lee Jones , Jingoo Han , Chanwoo Choi , Sachin Kamat , Rupesh Kumar , Lars-Peter Clausen , Pali Roh?r , Mark Brown , Rhyland Klein , David Woodhouse , Tony Lindgren , Russell King , Sebastian Reichel , aaro.koskinen@iki.fi, freemangordon@abv.bg, linux-omap@vger.kernel.org Subject: Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Message-ID: <20140125222929.GA30083@Nokia-N900> References: <1390411194-21410-1-git-send-email-jenny.tc@intel.com> <1390411194-21410-4-git-send-email-jenny.tc@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1390411194-21410-4-git-send-email-jenny.tc@intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > +config POWER_SUPPLY_CHARGING_ALGO_PSE > + bool "PSE compliant charging algorithm" > + help > + Say Y here to select PSE compliant charging algorithm. As per PSE > + standard the battery characteristics and thereby the charging rates It would be good to explain PSE here. > +#define MAINT_EXIT_OFFSET 50 /* mv */ mV > +/* PSE Modified Algo Structure */ > +/* Parameters defining the charging range */ > +struct psy_ps_temp_chg_table { > + /* upper temperature limit for each zone */ > + short int temp_up_lim; > + /* charge current and voltage */ > + short int full_chrg_vol; > + short int full_chrg_cur; It would be good to add units here. And vowels. > + /* type of battery */ > + u16 battery_type; > + u16 capacity; > + u16 voltage_max; > + /* charge termination current */ > + u16 chrg_term_ma; > + /* Low battery level voltage */ > + u16 low_batt_mv; > + /* upper and lower temperature limits on discharging */ > + u8 disch_tmp_ul; > + u8 disch_tmp_ll; tmp sounds like temporary, not temperature. just use full words. Add units. And u8 is probably not right type for temperature. > + /* number of temperature monitoring ranges */ > + u16 temp_mon_ranges; > + struct psy_ps_temp_chg_table temp_mon_range[BATT_TEMP_NR_RNG]; > + /* Lowest temperature supported */ > + short int temp_low_lim; Add units. Also check multiline comment codingstyle. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/