Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752325AbaAZNyw (ORCPT ); Sun, 26 Jan 2014 08:54:52 -0500 Received: from mail-ea0-f170.google.com ([209.85.215.170]:55082 "EHLO mail-ea0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbaAZNyv (ORCPT ); Sun, 26 Jan 2014 08:54:51 -0500 Date: Sun, 26 Jan 2014 14:54:44 +0100 From: Daniel Vetter To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Rik van Riel , Peter Zijlstra , Andrew Morton , Michel Lespinasse Subject: Re: [Intel-gfx] [PATCH] lib: Export interval_tree Message-ID: <20140126135444.GR9772@phenom.ffwll.local> Mail-Followup-To: Chris Wilson , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Rik van Riel , Peter Zijlstra , Andrew Morton , Michel Lespinasse References: <1390316872-15887-1-git-send-email-chris@chris-wilson.co.uk> <1390739073-4519-1-git-send-email-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1390739073-4519-1-git-send-email-chris@chris-wilson.co.uk> X-Operating-System: Linux phenom 3.12.0+ User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 26, 2014 at 12:24:33PM +0000, Chris Wilson wrote: > lib/interval_tree.c provides a simple interface for an interval-tree > (an augmented red-black tree) but is only built when testing the generic > macros for building interval-trees. For drivers with modest needs, > export the simple interval-tree library as is. > > v2: Lots of help from Michel Lespinasse to only compile the code > as required: > - make INTERVAL_TREE a config option > - make INTERVAL_TREE_TEST select the library functions > and sanitize the filenames & Makefile > - prepare interval_tree for being built as a module if required > > Signed-off-by: Chris Wilson > Cc: Michel Lespinasse > Cc: Rik van Riel > Cc: Peter Zijlstra > Cc: Andrea Arcangeli > Cc: David Woodhouse > Cc: Andrew Morton > --- [snip] > diff --git a/lib/interval_tree.c b/lib/interval_tree.c > index e6eb406f2d65..e4109f624e51 100644 > --- a/lib/interval_tree.c > +++ b/lib/interval_tree.c > @@ -1,6 +1,7 @@ > #include > #include > #include > +#include > > #define START(node) ((node)->start) > #define LAST(node) ((node)->last) > @@ -8,3 +9,8 @@ > INTERVAL_TREE_DEFINE(struct interval_tree_node, rb, > unsigned long, __subtree_last, > START, LAST,, interval_tree) > + > +EXPORT_SYMBOL(interval_tree_insert); > +EXPORT_SYMBOL(interval_tree_remove); > +EXPORT_SYMBOL(interval_tree_iter_first); > +EXPORT_SYMBOL(interval_tree_iter_next); Hm, I've thought kernel coding style nowadays is to put the EXPORT_SYMBOL right below the definition of the function? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/