Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752866AbaAZODk (ORCPT ); Sun, 26 Jan 2014 09:03:40 -0500 Received: from mail-qa0-f53.google.com ([209.85.216.53]:33624 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbaAZODj (ORCPT ); Sun, 26 Jan 2014 09:03:39 -0500 MIME-Version: 1.0 In-Reply-To: <20140126135444.GR9772@phenom.ffwll.local> References: <1390316872-15887-1-git-send-email-chris@chris-wilson.co.uk> <1390739073-4519-1-git-send-email-chris@chris-wilson.co.uk> <20140126135444.GR9772@phenom.ffwll.local> Date: Sun, 26 Jan 2014 06:03:38 -0800 Message-ID: Subject: Re: [Intel-gfx] [PATCH] lib: Export interval_tree From: Michel Lespinasse To: Chris Wilson , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Rik van Riel , Peter Zijlstra , Andrew Morton , Michel Lespinasse Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 26, 2014 at 5:54 AM, Daniel Vetter wrote: > On Sun, Jan 26, 2014 at 12:24:33PM +0000, Chris Wilson wrote: >> INTERVAL_TREE_DEFINE(struct interval_tree_node, rb, >> unsigned long, __subtree_last, >> START, LAST,, interval_tree) >> + >> +EXPORT_SYMBOL(interval_tree_insert); >> +EXPORT_SYMBOL(interval_tree_remove); >> +EXPORT_SYMBOL(interval_tree_iter_first); >> +EXPORT_SYMBOL(interval_tree_iter_next); > > Hm, I've thought kernel coding style nowadays is to put the EXPORT_SYMBOL > right below the definition of the function? INTERVAL_TREE_DEFINE generates the definitions of these functions. -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/